Skip to content

[SPARK-2366] [SQL] Add column pruning for the right side of LeftSemi join.#1301

Closed
ueshin wants to merge 3 commits into
apache:masterfrom
ueshin:issues/SPARK-2366
Closed

[SPARK-2366] [SQL] Add column pruning for the right side of LeftSemi join.#1301
ueshin wants to merge 3 commits into
apache:masterfrom
ueshin:issues/SPARK-2366

Conversation

@ueshin

@ueshin ueshin commented Jul 4, 2014

Copy link
Copy Markdown
Member

The right side of LeftSemi join needs columns only used in join condition.

@AmplabJenkins

AmplabJenkins commented Jul 4, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jul 4, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jul 4, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Jul 4, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16344/

marmbrus
marmbrus reviewed Jul 4, 2014
View reviewed changes
Comment thread sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala Outdated

@marmbrus marmbrus Jul 4, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "pruneJoinChild". It took me a little bit to figure out why this was okay, as shadowing the outside function is a little confusing.

@marmbrus

marmbrus commented Jul 4, 2014

Copy link
Copy Markdown
Contributor

Another awesome addition to the optimizer! Only minor comments.

@ueshin

ueshin commented Jul 5, 2014

Copy link
Copy Markdown
Member Author

Thank you for your comments.
Fixed and pushed.

@AmplabJenkins

AmplabJenkins commented Jul 5, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jul 5, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jul 5, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Jul 5, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16351/

@asfgit asfgit closed this in 3da8df9 Jul 5, 2014
@marmbrus

marmbrus commented Jul 5, 2014

Copy link
Copy Markdown
Contributor

Thanks! Merged into master and 1.0.

asfgit pushed a commit that referenced this pull request Jul 5, 2014
@ueshin @marmbrus
[SPARK-2366] [SQL] Add column pruning for the right side of LeftSemi …
3aa52be 
…join.

The right side of `LeftSemi` join needs columns only used in join condition.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #1301 from ueshin/issues/SPARK-2366 and squashes the following commits:

7677a39 [Takuya UESHIN] Update comments.
786d3a0 [Takuya UESHIN] Rename method name.
e0957b1 [Takuya UESHIN] Add column pruning for the right side of LeftSemi join.

(cherry picked from commit 3da8df9)
Signed-off-by: Michael Armbrust <michael@databricks.com>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@ueshin @conviva-zz
[SPARK-2366] [SQL] Add column pruning for the right side of LeftSemi …
424334d 
…join.

The right side of `LeftSemi` join needs columns only used in join condition.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes apache#1301 from ueshin/issues/SPARK-2366 and squashes the following commits:

7677a39 [Takuya UESHIN] Update comments.
786d3a0 [Takuya UESHIN] Rename method name.
e0957b1 [Takuya UESHIN] Add column pruning for the right side of LeftSemi join.
wangyum added a commit that referenced this pull request May 26, 2023
@wangyum
[CARMEL-5941] Add how to request HDM data access to error message (#1301
a6d9e7c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ueshin @AmplabJenkins @marmbrus